-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include TESTS in doc preview for PRs #38449
Conversation
Documentation preview for this PR (built with commit 3162bc8; changes) is ready! 🎉 |
Interesting idea. Do you have plans beyond this for the TESTS blocks? |
3162bc8
to
29e0980
Compare
No. Actually while investigating the cause of the hunk 1 in https://doc-pr-38468--sagemath.netlify.app/changes, I have now realized that this PR won't work as I expected, at least with the current infrastructure. When we compute diffs to create CHANGES.html, we compare the "new" doc for the PR with the "old" doc built by One way to escape the dilemma is to get the "old" doc from the artifact produced by
|
29e0980
to
7c5ec6a
Compare
I did necessary refactoring to implement this PR. Now doc build for pull request event downloads doc-develop artifact to compute diffs to create CHANGES.html. |
Done. |
171f7b6
to
2710165
Compare
2710165
to
e7ee109
Compare
@mkoeppe I think this PR is now tasty. |
The last commit is to mitigate the "out of disk space" failure. |
82e2f2e
to
b9567a6
Compare
build-doc CI step is failing, as you introduced new "target" doc-develop. Is there a way to fix this? |
It is expected, and cannot be "fixed" here. The artifact doc-develop will be generated at next beta release after merging this pr. If you want to see a test result, I will prepare one in my repo. Wait some minutes. |
doc-build for a dummy PR for testing is running here: https://github.com/kwankyu/sage/actions/runs/11789320959/job/32837887930 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks! |
We include TESTS blocks in development documentation, so that they are visible at least during development. Then not to ruin CHANGES.html, we refactor doc build github workflow. The idea is to upload artifact `doc-develop` so that doc diffs are computed against the doc contained in the artifact. test: https://doc-develop--sagemath- test.netlify.app/html/en/reference/structure/sage/structure/sage_object Look around for new "TESTS" blocks. We also remove all spurious diffs caused by EXAMPLES tabs indices change. Tests for PR event: doc-develop artifact: https://github.com/kwankyu/sage/actions/runs/11787561475 doc-build workflow run: https://github.com/kwankyu/sage/actions/runs/11789320959/job/32837887930 Note that doc build for this PR itself fails here, of course. We may ignore this. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> sagemath#38468 URL: sagemath#38449 Reported by: Kwankyu Lee Reviewer(s): Dima Pasechnik
We include TESTS blocks in development documentation, so that they are visible at least during development.
Then not to ruin CHANGES.html, we refactor doc build github workflow. The idea is to upload artifact
doc-develop
so that doc diffs are computed against the doc contained in the artifact.test: https://doc-develop--sagemath-test.netlify.app/html/en/reference/structure/sage/structure/sage_object Look around for new "TESTS" blocks.
We also remove all spurious diffs caused by EXAMPLES tabs indices change. Tests for PR event:
doc-develop artifact: https://github.com/kwankyu/sage/actions/runs/11787561475
doc-build workflow run: https://github.com/kwankyu/sage/actions/runs/11789320959/job/32837887930
Note that doc build for this PR itself fails here, of course. We may ignore this.
📝 Checklist
⌛ Dependencies
#38468