Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix many pep8 E302 warnings in repl,rings,schemes,sat,etc #38477

Merged

Conversation

fchapoton
Copy link
Contributor

mostly scripted with autopep8 except for a few files handled by hand

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

Copy link

github-actions bot commented Aug 6, 2024

Documentation preview for this PR (built with commit 1046e84; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@vincentmacri vincentmacri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, I missed that issue.

LGTM.

@fchapoton
Copy link
Contributor Author

setting back to positive after auto-rebase (I should not have done that, sigh)

@dcoudert
Copy link
Contributor

setting back to positive after auto-rebase (I should not have done that, sigh)

I was about to do it anyway.

vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 27, 2024
…at,etc

    
mostly scripted with `autopep8` except for a few files handled by hand

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#38477
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert, Vincent Macri
@vbraun vbraun merged commit 1d9ac17 into sagemath:develop Sep 3, 2024
18 of 20 checks passed
@mkoeppe mkoeppe added this to the sage-10.5 milestone Sep 3, 2024
@fchapoton fchapoton deleted the fixing_some_E302_rings_schemes_etc branch September 4, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants