convenience methods for field embeddings #38487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One minor (relevant) error with tests/docs/CI. |
|
Thanks, should be fixed. |
yyyyx4
force-pushed
the
public/convenience_methods_for_field_embeddings
branch
from
b3429d2
to
1e82473
Compare
GiacomoPope
approved these changes
Aug 21, 2024
|
Tiny comment about documentation, otherwise looks good to me. |
|
Indeed, thanks, done. |
|
Test fail |
github-actions
bot
added
s: needs review
and removed
s: positive review
s: needs work
labels
S17A05
reviewed
Oct 14, 2024
S17A05
reviewed
Oct 14, 2024
S17A05
reviewed
Oct 14, 2024
Co-authored-by: Giacomo Pope <44242839+GiacomoPope@users.noreply.github.com>
…nical ...hence the output here would be more or less meaningless. We should fail instead, until algebraic closures of non-prime finite fields are supported "properly". (reverts part of 87e912b)
yyyyx4
force-pushed
the
public/convenience_methods_for_field_embeddings
branch
from
61fe1af
to
a2fdcc9
Compare
|
Thanks for the review, @S17A05! I think I've addressed all your comments. |
|
Documentation preview for this PR (built with commit a2fdcc9; changes) is ready! 🎉 |
Thanks for the changes, looks good to me now! (For the record: The timeout in the long [p-z] tests is unrelated) |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 23, 2024
Currently, the best(?) way to compute embeddings between fields is
somewhat hidden inside the `Hom` object. In this patch we add helper
methods to access such embeddings. In addition, we add an
`.algebraic_closure()` method to non-prime finite fields.
These seem useful.
URL: sagemath#38487
Reported by: Lorenz Panny
Reviewer(s): Giacomo Pope, Sebastian A. Spindler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the best(?) way to compute embeddings between fields is somewhat hidden inside the
Homobject. In this patch we add helper methods to access such embeddings. In addition, we add an.algebraic_closure()method to non-prime finite fields.These seem useful.