prevent crash in order_from_multiple() due to rounding error #38490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 0b172b1; changes) is ready! 🎉 |
yyyyx4
changed the title
|
god. |
|
good* |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 11, 2024
…ing error Due to what appears to be rounding errors, the value of `k` here can be zero, which results in the list `L` being split as `L1 == []` and `L2 == L`. This causes an error in the next recursive call. Simple workaround: If either `L1` or `L2` would end up being empty, we split the lists in the middle instead. Resolves sagemath#38489. URL: sagemath#38490 Reported by: Lorenz Panny Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 27, 2024
…ing error
Due to what appears to be rounding errors, the value of `k` here can be
zero, which results in the list `L` being split as `L1 == []` and `L2 ==
L`. This causes an error in the next recursive call.
Simple workaround: If either `L1` or `L2` would end up being empty, we
split the lists in the middle instead.
Resolves sagemath#38489.
URL: sagemath#38490
Reported by: Lorenz Panny
Reviewer(s):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to what appears to be rounding errors, the value of
khere can be zero, which results in the listLbeing split asL1 == []andL2 == L. This causes an error in the next recursive call.Simple workaround: If either
L1orL2would end up being empty, we split the lists in the middle instead.Resolves #38489.