CI Linux: Consolidate jobs #38518
Merged
CI Linux: Consolidate jobs #38518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkgs/sagemath-standard/tox.ini: Add environment sagepython-constraints_pkgs[-norequirements]
…ts_pkgs-norequirements
… into constraints_pkgs
…ts_pkgs-norequirements' runs
…constraints_pkgs-norequirements' runs
…_pkgs-norequirements' runs
… for 'constraints_pkgs-norequirements' runs
…experimental-0-o, experimental-p-z
|
Documentation preview for this PR (built with commit ee30cbf; changes) is ready! 🎉 |
added 5 commits
August 17, 2024 17:33
…ecific to sagemath-standard
…ecific to sagemath-standard (fixup)
kwankyu
reviewed
Aug 18, 2024
|
This simplification is very welcome. I am just curious what was the purpose of |
|
Before the runners were upgraded, the jobs did not fit in the 6 hour time limit. |
|
Ah, I see. No merge conflict with #37434? |
|
This looks good to me. Let me know when the test run of the (merged) workflow is done. |
kwankyu
approved these changes
Aug 18, 2024
kwankyu
reviewed
Aug 18, 2024
|
@fchapoton fixed the lint errors in #38518 |
|
Thanks! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 27, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Thanks to the more powerful runners in use since early 2024, we can do away with the splits between - `standard-pre` and `standard` - `minimal-pre` and `minimal` - `optional-0-o` and `optional-p-z` - `experimental-0-o` and `experimental-p-z` This makes the CI runs a bit easier to navigate for those who look at them. - Test run: https://github.com/mkoeppe/sage/actions/runs/10438362191 This should also fix "No space left on device" aborts as seen for example in https://github.com/mkoeppe/sage/actions/runs/10426436105 for standard-pre (where we did not use to maximize the available disk space). ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - Depends on sagemath#37434 (merged here) URL: sagemath#38518 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee, Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to the more powerful runners in use since early 2024, we can do away with the splits between
standard-preandstandardminimal-preandminimaloptional-0-oandoptional-p-zexperimental-0-oandexperimental-p-zThis makes the CI runs a bit easier to navigate for those who look at them.
This should also fix "No space left on device" aborts as seen for example in https://github.com/mkoeppe/sage/actions/runs/10426436105 for standard-pre (where we did not use to maximize the available disk space).
📝 Checklist
⌛ Dependencies
PIP_CONSTRAINT=$SAGE_ROOT/constraints_pkgs.txt#37434 (merged here)