-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert cysignals build constraint #38556
Conversation
Reverts sagemath@95428a1 which broke the conda ci.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Documentation preview for this PR (built with commit 0166cab; changes) is ready! 🎉 |
Thanks @dimpase for the quick review. Tests are passing (Conda (macos-latest) failure is already there in main branch) > marking as ci fix to directly apply to other PRs as well. |
One does not revert without doing due diligence on why the change was made etc. |
the changes by @mkoeppe were not taking into account the needs of sagelib package maintainers, that's why parts of them need to be reversed |
We have set this PR to disputed; participants may set it to positive review by counting votes in accordance with the disputed PR policy. |
Reverts 95428a1 which broke the conda ci.
📝 Checklist
⌛ Dependencies