Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert cysignals build constraint #38556

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Conversation

tobiasdiez
Copy link
Contributor

Reverts 95428a1 which broke the conda ci.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Reverts sagemath@95428a1 which broke the conda ci.
Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

Documentation preview for this PR (built with commit 0166cab; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@tobiasdiez
Copy link
Contributor Author

Thanks @dimpase for the quick review. Tests are passing (Conda (macos-latest) failure is already there in main branch) > marking as ci fix to directly apply to other PRs as well.

@tobiasdiez tobiasdiez added the p: CI Fix merged before running CI tests label Aug 23, 2024
@mkoeppe
Copy link
Contributor

mkoeppe commented Aug 23, 2024

One does not revert without doing due diligence on why the change was made etc.

@dimpase
Copy link
Member

dimpase commented Aug 24, 2024

the changes by @mkoeppe were not taking into account the needs of sagelib package maintainers, that's why parts of them need to be reversed

@roed314 roed314 added the disputed PR is waiting for community vote, see https://groups.google.com/g/sage-devel/c/IgBYUJl33SQ label Sep 13, 2024
@roed314
Copy link
Contributor

roed314 commented Sep 13, 2024

We have set this PR to disputed; participants may set it to positive review by counting votes in accordance with the disputed PR policy.
The Sage Code of Conduct Committee

@tobiasdiez
Copy link
Contributor Author

There doesn't seem to be any need for further discussions. Setting this to positive review due to
+1: @dimpase, me
-1: @mkoeppe (perhaps)

@vbraun vbraun merged commit ff78ee9 into sagemath:develop Sep 29, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disputed PR is waiting for community vote, see https://groups.google.com/g/sage-devel/c/IgBYUJl33SQ p: CI Fix merged before running CI tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants