Add is_integral method to algebraic numbers #38592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwankyu
reviewed
Aug 31, 2024
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 5, 2024
For symmetry with existing methods e.g. `QQ(1).is_integral` or such
method on elements of number fields.
Implementation pretty much copied from `NumberFieldElement`.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
URL: sagemath#38592
Reported by: user202729
Reviewer(s): Kwankyu Lee, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 6, 2024
For symmetry with existing methods e.g. `QQ(1).is_integral` or such
method on elements of number fields.
Implementation pretty much copied from `NumberFieldElement`.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
URL: sagemath#38592
Reported by: user202729
Reviewer(s): Kwankyu Lee, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 8, 2024
For symmetry with existing methods e.g. `QQ(1).is_integral` or such
method on elements of number fields.
Implementation pretty much copied from `NumberFieldElement`.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
URL: sagemath#38592
Reported by: user202729
Reviewer(s): Kwankyu Lee, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 8, 2024
For symmetry with existing methods e.g. `QQ(1).is_integral` or such
method on elements of number fields.
Implementation pretty much copied from `NumberFieldElement`.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
URL: sagemath#38592
Reported by: user202729
Reviewer(s): Kwankyu Lee, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 10, 2024
For symmetry with existing methods e.g. `QQ(1).is_integral` or such
method on elements of number fields.
Implementation pretty much copied from `NumberFieldElement`.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
URL: sagemath#38592
Reported by: user202729
Reviewer(s): Kwankyu Lee, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 12, 2024
For symmetry with existing methods e.g. `QQ(1).is_integral` or such
method on elements of number fields.
Implementation pretty much copied from `NumberFieldElement`.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
URL: sagemath#38592
Reported by: user202729
Reviewer(s): Kwankyu Lee, user202729
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For symmetry with existing methods e.g.
QQ(1).is_integralor such method on elements of number fields.Implementation pretty much copied from
NumberFieldElement.📝 Checklist