Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

categories/morphism.pyx: remove some noexcepts #38613

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

gmou3
Copy link
Contributor

@gmou3 gmou3 commented Sep 4, 2024

Remove ignored noexcepts for functions with Python return types.

[sagelib-10.5.beta3] [spkg-install]     warning: sage/categories/morphism.pyx:801:26: noexcept clause is ignored for function returning Python object
[sagelib-10.5.beta3] [spkg-install]     warning: sage/categories/morphism.pyx:826:22: noexcept clause is ignored for function returning Python object

Copy link

github-actions bot commented Sep 4, 2024

Documentation preview for this PR (built with commit 36316c0; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 12, 2024
    
Remove ignored `noexcept`s for functions with `Python` return types.

```
[sagelib-10.5.beta3] [spkg-install]     warning:
sage/categories/morphism.pyx:801:26: noexcept clause is ignored for
function returning Python object
[sagelib-10.5.beta3] [spkg-install]     warning:
sage/categories/morphism.pyx:826:22: noexcept clause is ignored for
function returning Python object
```
    
URL: sagemath#38613
Reported by: gmou3
Reviewer(s): Kwankyu Lee
@vbraun vbraun merged commit e9f546b into sagemath:develop Sep 15, 2024
17 of 21 checks passed
@gmou3 gmou3 deleted the morphism_noexcept_ignored_python branch September 16, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants