-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add py3.9 support to sage_autodoc.py #38619
Conversation
In the CI, I see:
|
I should have double checked that an import of |
Documentation preview for this PR (built with commit 57f5d16; changes) is ready! 🎉 |
Looks a lot healthier now. |
This error still shows up with Python 3.9:
|
Hopefully, I will not have to make those into blocks conditional to the version of python. And they will be enough. |
|
This does the trick, thanks very much! |
This PR corrects the fact the sage_autodoc.py changes needed for sphinx 8 dropped python 3.9 support. This is a consequence of the fact that sphinx 8 has dropped python 3.9. Since we still want to support python 3.9, some support has to be re- introduced. See sagemath#38549 (comment) and after. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#38619 Reported by: François Bissey Reviewer(s):
And it breaks sphinx-8. I will need to add some try expect blocks. Since it is being merged, that will be another follow up. |
This PR corrects the fact the sage_autodoc.py changes needed for sphinx 8 dropped python 3.9 support. This is a consequence of the fact that sphinx 8 has dropped python 3.9. Since we still want to support python 3.9, some support has to be re- introduced. See sagemath#38549 (comment) and after. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#38619 Reported by: François Bissey Reviewer(s):
@vbraun I see you have this in your merge tree, but it turns out it needs more work. Is it OK with you if I push some more commits or you'd prefer a follow up? |
you can keep working on it |
@mkoeppe if you would like to check that it is still working for you on py3.9. Unless you find something not working, it should be the last tweak. |
It works well with py3.9. LGTM. |
Thanks! |
This PR corrects the fact the sage_autodoc.py changes needed for sphinx 8 dropped python 3.9 support. This is a consequence of the fact that sphinx 8 has dropped python 3.9. Since we still want to support python 3.9, some support has to be re- introduced. See sagemath#38549 (comment) and after. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#38619 Reported by: François Bissey Reviewer(s): Kwankyu Lee
This PR corrects the fact the sage_autodoc.py changes needed for sphinx 8 dropped python 3.9 support. This is a consequence of the fact that sphinx 8 has dropped python 3.9.
Since we still want to support python 3.9, some support has to be re-introduced.
See #38549 (comment) and after.
📝 Checklist