New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some fixes for E241 #38641

Merged

vbraun merged 5 commits into sagemath:develop from fchapoton:fixing_partial_E241

Sep 22, 2024

Contributor

fchapoton commented Sep 8, 2024

This is fixing a lot (but not all) E241 warnings about

E241 multiple spaces after ','

📝 Checklist

The title is concise and informative.
The description explains in detail what this PR is about.
I have linked a relevant issue or discussion.
I have created tests covering the changes.
I have updated the documentation and checked the documentation preview.


          some fixes for E241

7f9f433

github-actions bot added the s: needs review label

fchapoton added the t: refactoring label

github-actions bot commented Sep 8, 2024 •

edited

Loading

Documentation preview for this PR (built with commit b89bc40; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

kwankyu reviewed

View reviewed changes

src/sage/combinat/root_system/type_D.py Outdated Show resolved Hide resolved

kwankyu reviewed

View reviewed changes

src/sage/combinat/root_system/type_E.py Outdated Show resolved Hide resolved

kwankyu reviewed

View reviewed changes

src/sage/combinat/root_system/type_F.py Outdated Show resolved Hide resolved

kwankyu reviewed

View reviewed changes

src/sage/combinat/root_system/type_G.py Outdated Show resolved Hide resolved

kwankyu reviewed

View reviewed changes

src/sage/combinat/sf/dual.py Outdated Show resolved Hide resolved

kwankyu reviewed

View reviewed changes

src/sage/combinat/sf/schur.py Outdated Show resolved Hide resolved

Collaborator

kwankyu commented Sep 9, 2024

Otherwise lgtm.


          fix suggested details

c5a58b9

kwankyu reviewed

View reviewed changes

src/sage/combinat/root_system/type_A.py Outdated Show resolved Hide resolved

kwankyu reviewed

View reviewed changes

src/sage/combinat/root_system/type_C.py Outdated Show resolved Hide resolved

kwankyu reviewed

View reviewed changes

src/sage/combinat/root_system/type_D.py Outdated Show resolved Hide resolved

fchapoton added 2 commits

September 9, 2024 07:45


          more suggested details

e4bc3b1


          remove wrong pickle register in type D

b89bc40

kwankyu approved these changes

View reviewed changes

Collaborator

kwankyu left a comment

LGTM.

kwankyu added s: positive review and removed s: needs review labels


          Merge branch 'develop' into fixing_partial_E241

dbffb02

github-actions bot added s: needs review and removed s: positive review labels

Contributor Author

fchapoton commented Sep 18, 2024

after a trivial fix, setting back to positive

fchapoton added s: positive review and removed s: needs review labels

vbraun pushed a commit to vbraun/sage that referenced this pull request


          sagemathgh-38641: some fixes for E241

4fefd32

    
This is fixing a lot (but not all) E241 warnings about

E241 multiple spaces after ','

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#38641
Reported by: Frédéric Chapoton
Reviewer(s): Frédéric Chapoton, Kwankyu Lee

vbraun merged commit b43a449 into sagemath:develop

14 of 18 checks passed

fchapoton deleted the fixing_partial_E241 branch

September 22, 2024 11:21

github-actions bot removed the s: positive review label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels