Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add typing annotation in temporary_file #38646

Merged
merged 3 commits into from
Sep 15, 2024
Merged

add typing annotation in temporary_file #38646

merged 3 commits into from
Sep 15, 2024

Conversation

fchapoton
Copy link
Contributor

add some typing annotation in the modified file

also remove one unused import

and some traces of python 2

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 11, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 7fc7e9b; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

vincentmacri
vincentmacri approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@vincentmacri vincentmacri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vbraun vbraun merged commit 27fce1f into sagemath:develop Sep 15, 2024
15 of 18 checks passed
@fchapoton fchapoton deleted the types_in_temporary_file branch September 16, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentmacri vincentmacri vincentmacri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fchapoton @vincentmacri @vbraun