src/sage/misc/package.py: use gnulib instead of conway_polynomials in tests #38661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit e282f46; changes) is ready! 🎉 |
|
This fixes a harmless but annoying test failure with "gnulib" should be a safe alternative because it's not a real package, only a placeholder for the |
|
please rebase |
… tests
The conway_polynomials package now has an spkg-configure.m4, and may
not be installed as an SPKG. In that case, several tests fail. For
example,
File "src/sage/misc/package.py", line 404, in
sage.misc.package.installed_packages
Failed example:
sorted(installed_packages().keys())
Expected:
[...'conway_polynomials', ...]
Got:
['combinatorial_designs',
'elliptic_curves',
'execnet',
'gnulib',
'gnumake_tokenpool',
'graphs',
'h11',
'iniconfig',
'jmol',
'polytopes_db',
'pyproject_hooks',
'pytest_mock',
'pytest_xdist',
'python3_venv',
'python_build',
'sage_conf',
'sage_setup',
'sagelib',
'threejs']
The gnulib package seems like a safe alternative.
orlitzky
force-pushed
the
fix-package-tests
branch
from
827e05b
to
e282f46
Compare
|
no problem, done |
dimpase
added
c: build: configure
s: positive review
and removed
s: needs review
labels
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 27, 2024
…way_polynomials in tests
The conway_polynomials package now has an `spkg-configure.m4`, and may
not be installed as an SPKG. In that case, several tests fail. For
example,
```
File "src/sage/misc/package.py", line 404, in
sage.misc.package.installed_packages
Failed example:
sorted(installed_packages().keys())
Expected:
[...'conway_polynomials', ...]
Got:
['combinatorial_designs',
'elliptic_curves',
'execnet',
'gnulib',
'gnumake_tokenpool',
'graphs',
'h11',
'iniconfig',
'jmol',
'polytopes_db',
'pyproject_hooks',
'pytest_mock',
'pytest_xdist',
'python3_venv',
'python_build',
'sage_conf',
'sage_setup',
'sagelib',
'threejs']
```
The gnulib package seems like a safe alternative.
URL: sagemath#38661
Reported by: Michael Orlitzky
Reviewer(s): Dima Pasechnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conway_polynomials package now has an
spkg-configure.m4, and may not be installed as an SPKG. In that case, several tests fail. For example,The gnulib package seems like a safe alternative.