configure.ac: disable more packages with --disable-notebook #38662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 5fbd4b4; changes) is ready! 🎉 |
|
please rebase |
The h11 package is used only by httpcore, and httpcore is used only by httpx, and httpx is used only by jupyterlab. Since jupyterlab is already disabled by --disable-notebook, the others can be too.
orlitzky
force-pushed
the
disable-more-notebook-deps
branch
from
d3d690a
to
5fbd4b4
Compare
|
sure thing, done |
dimpase
approved these changes
Sep 24, 2024
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 27, 2024
…notebook
The h11 package is used only by httpcore, and httpcore is used only by
httpx, and httpx is used only by jupyterlab. Since jupyterlab is already
disabled by `--disable-notebook`, the others can be too.
URL: sagemath#38662
Reported by: Michael Orlitzky
Reviewer(s): Dima Pasechnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The h11 package is used only by httpcore, and httpcore is used only by httpx, and httpx is used only by jupyterlab. Since jupyterlab is already disabled by
--disable-notebook, the others can be too.