construct order ideals by default for number-field orders #38671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyyyx4
added
p: major / 3
t: enhancement
c: number fields
and removed
s: needs review
labels
|
Documentation preview for this PR (built with commit f876d5b; changes) is ready! 🎉 |
yyyyx4
force-pushed
the
public/construct_order_ideals_by_default
branch
from
8f51bee
to
fe7ae08
Compare
kwankyu
approved these changes
Sep 24, 2024
|
Thank you! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 27, 2024
…orders
This completes the change begun in sagemath#34806 and sagemath#35762: When constructing
ideals of an order, return an ideal of that order, rather than a
fractional ideal of the ambient number field.
URL: sagemath#38671
Reported by: Lorenz Panny
Reviewer(s): Kwankyu Lee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes the change begun in #34806 and #35762: When constructing ideals of an order, return an ideal of that order, rather than a fractional ideal of the ambient number field.