Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cythonize the chain polynomials of posets #38674

Merged
merged 2 commits into from
Sep 22, 2024
Merged

cythonize the chain polynomials of posets #38674

merged 2 commits into from
Sep 22, 2024

Conversation

fchapoton
Copy link
Contributor

for the sake of speed

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 18, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 6b50b66; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

dcoudert
dcoudert suggested changes Sep 21, 2024
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM.

src/sage/combinat/posets/hasse_cython_flint.pyx Outdated Show resolved Hide resolved
dcoudert
dcoudert approved these changes Sep 21, 2024
View reviewed changes
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun vbraun merged commit f4305c7 into sagemath:develop Sep 22, 2024
18 of 19 checks passed
@fchapoton fchapoton deleted the cythonize_chain_poly branch September 22, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcoudert dcoudert dcoudert approved these changes

Assignees
No one assigned
Labels
c: combinatorics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fchapoton @dcoudert @vbraun