Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests with singular 4.4.0p3 #38689

Merged
merged 3 commits into from
Sep 29, 2024

Conversation

antonio-rojas
Copy link
Contributor

Fuzz some tests to make then pass with singular>=4.4.0p3, which returns different Gröbner bases in some cases

Copy link

github-actions bot commented Sep 20, 2024

Documentation preview for this PR (built with commit 84dd3e5; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@@ -176,7 +176,7 @@
The Groebner basis modulo any product of the prime factors is also non-trivial::

sage: I.change_ring(P.change_ring(IntegerModRing(2 * 7))).groebner_basis()
[x + 9*y + 13*z, y^2 + 3*y, y*z + 7*y + 6, 2*y + 6, z^2 + 3, 2*z + 10]
[x + ..., y^2 + 3*y, y*z + 7*y + 6, 2*y + 6, z^2 + 3, 2*z + 10]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text above this test says that it's checking that the basis is non-trivial, so we could probably fix this one forever by simply comparing it to the trivial basis and looking for False

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list of leading monomials is deterministic so I think it's good to keep testing it, even though it's not the main goal of the test.

@orlitzky
Copy link
Contributor

Ok, thanks, LGTM then.

@tornaria
Copy link
Contributor

I now think that the "p" in singular version means "pre release" (i.e. "alpha" or "beta"; instead of "patch" as I used to think) since they keep breaking API and everything in these.

IOW, I'm proposing that we (distros, including sage-the-distro) stick with 4.4.0 until either 4.4.1 or 4.5.0 is released.

vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 27, 2024
    
Fuzz some tests to make then pass with singular>=4.4.0p3, which returns
different Gröbner bases in some cases
    
URL: sagemath#38689
Reported by: Antonio Rojas
Reviewer(s): Antonio Rojas, Michael Orlitzky
@vbraun vbraun merged commit 3cc2491 into sagemath:develop Sep 29, 2024
19 checks passed
@antonio-rojas antonio-rojas deleted the singular-4.4.0.p3 branch September 29, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants