Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some details in permutations #38704

Merged
merged 2 commits into from
Sep 29, 2024
Merged

Conversation

fchapoton
Copy link
Contributor

including a fix to one method so that it does what it says

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

Copy link

github-actions bot commented Sep 23, 2024

Documentation preview for this PR (built with commit 7f3cefb; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@kwankyu
Copy link
Collaborator

kwankyu commented Sep 24, 2024

Otherwise lgtm.

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 27, 2024
    
including a fix to one method so that it does what it says

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#38704
Reported by: Frédéric Chapoton
Reviewer(s): Kwankyu Lee
@vbraun vbraun merged commit a2f9840 into sagemath:develop Sep 29, 2024
21 checks passed
@fchapoton fchapoton deleted the details_permutation branch September 29, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants