-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move metadata from src/setup.cfg.m4
to src/pyproject.toml
#38714
base: develop
Are you sure you want to change the base?
Conversation
Documentation preview for this PR (built with commit 584508d; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I don't see change in contents.
+1 from me. |
The predecessor PR #37902 was set to "disputed" 3 weeks ago.
|
+1 from me too. Vote count is now: In favor: @mkoeppe (PR author), @kwankyu, @NathanDunfield |
@tobiasdiez put a subset of the changes here on #38727. I have set that to "needs work" because the cherry-picked subset duplicates the version constraints, violating our long-standing policy of single-sourcing version constraints. |
53307c8
to
584508d
Compare
pkgs/sage-conf
: Move metadata fromsetup.cfg
topyproject.toml
#36561Goal of the PR:
setup.cfg
in favor ofpyproject.toml
.Status quo:
src/setup.cfg.m4
; at bootstrapping time,src/setup.cfg
is generated, and the version constraints obtained viasage-get-system-packages install-requires
are substituted.build/pkgs/*/version_requirements.txt
(these files until not long ago were calledinstall-requires.txt
).src/pyproject.toml
the single source of truth", thesebuild/pkgs/*/version_requirements.txt
files are not source files but are generated at bootstrap time. The lists of these special packages appear 1x in.gitignore
, 1x inMakefile
, 2x inbootstrap
.src/pyproject.toml
file is done by the scriptbuild/bin/sage-get-system-packages install-requires[-toml]
.Scope and implementation strategy of the PR:
version_requirements.txt
files source files again; for the special packages, without actual version information.build/bin/sage-get-system-packages install-requires[-toml]
so as to read not only from the build requirements but also from the runtime dependencies now declared insrc/pyproject.toml
.src/pyproject.toml
, leave behindbuild/pkgs/*/version_requirements.txt
files without version constraints.src/pyproject.toml
.Outside of the scope of this PR:
📝 Checklist
⌛ Dependencies