Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing some suggestions by ruff #38740

Merged
merged 3 commits into from
Oct 26, 2024
Merged

Conversation

fchapoton
Copy link
Contributor

some by hand, some scripted

in particular, removal of useless parentheses

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

Copy link

github-actions bot commented Sep 29, 2024

Documentation preview for this PR (built with commit a5489f7; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 5, 2024
    
some by hand, some scripted

in particular, removal of useless parentheses

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#38740
Reported by: Frédéric Chapoton
Reviewer(s): Kwankyu Lee
@kwankyu
Copy link
Collaborator

kwankyu commented Oct 17, 2024

Thanks.

vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 18, 2024
    
some by hand, some scripted

in particular, removal of useless parentheses

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#38740
Reported by: Frédéric Chapoton
Reviewer(s): Frédéric Chapoton, Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 20, 2024
    
some by hand, some scripted

in particular, removal of useless parentheses

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#38740
Reported by: Frédéric Chapoton
Reviewer(s): Frédéric Chapoton, Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 23, 2024
    
some by hand, some scripted

in particular, removal of useless parentheses

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#38740
Reported by: Frédéric Chapoton
Reviewer(s): Frédéric Chapoton, Kwankyu Lee
@vbraun vbraun merged commit 2be2d84 into sagemath:develop Oct 26, 2024
19 of 20 checks passed
@fchapoton fchapoton deleted the some_ruff_changes branch October 26, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants