move power series to Parent #38741
Merged
move power series to Parent #38741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchapoton
force-pushed
the
move_power_series_to_Parent
branch
from
1692769
to
1480abb
Compare
|
the case of Laurent series triggers a failure in Drinfeld modules, so it is kept for another pull request |
mantepse
reviewed
Sep 29, 2024
| sage: M.gens() | ||
| (v0, v1, v2) | ||
| """ | ||
|
|
There was a problem hiding this comment.
This blank line is unconventional, no?
There was a problem hiding this comment.
oui, c'est vrai, merci. J'ai corrigé ça.
|
Documentation preview for this PR (built with commit 576784f; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 5, 2024
make the power series rings inherit from Parent instead of the auld
`Ring` class
### 📝 Checklist
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
URL: sagemath#38741
Reported by: Frédéric Chapoton
Reviewer(s): Frédéric Chapoton, Martin Rubey
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 9, 2024
make the power series rings inherit from Parent instead of the auld
`Ring` class
### 📝 Checklist
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
URL: sagemath#38741
Reported by: Frédéric Chapoton
Reviewer(s): Frédéric Chapoton, Martin Rubey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make the power series rings inherit from Parent instead of the auld
Ringclass📝 Checklist