Corrects some inner products in root systems #38750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tscrim
requested changes
Oct 2, 2024
| continue | ||
| result += c*self_mc[t] | ||
| return result | ||
| raise TypeError(f"Don't know how to coerce {lambdacheck} into root or coroot space of {self}") |
There was a problem hiding this comment.
Suggested change
| raise TypeError(f"Don't know how to coerce {lambdacheck} into root or coroot space of {self}") |
tscrim
reviewed
Oct 2, 2024
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
|
Documentation preview for this PR (built with commit e08bb52; changes) is ready! 🎉 |
tscrim
approved these changes
Oct 4, 2024
tscrim
added
t: bug
s: positive review
c: combinatorics
and removed
s: needs review
labels
|
Thank you. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 5, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Goal of this PR: * Fix Exhibit A in sagemath#15325 * Exhibits B and C in the issue are ignored because they are not strictly speaking errors Status quo: * Some inner products for elements of root spaces or ambient spaces give wrong answers or raise exceptions Fix: * Adds a few lines of code to scalar product functions in ambient_space and root_space * TESTS were added to scalar product member functions to exhibit fixing this issue Notes: * I am unable to verify that the documentation builds because I cannot build the documentation (build problems with this version of Sage) A more thorough test of this functionality, which checks Exhibit A from the issue on more cases, is provided by the following code snippet: ``` for ct in [['G', 2], ['F', 4], ['E', 8], ['E', 7]] + [[x, 6] for x in ['A', 'B', 'C', 'D', 'E']]: rt = RootSystem(ct) print(ct) lat = rt.root_lattice() spc = rt.ambient_space() ell = lat.rank() C = rt.cartan_matrix() for i in range(1,ell+1): assert lat.simple_root(i) == spc.simple_root(i) assert lat.simple_coroot(i) == spc.simple_coroot(i) for j in range(1,ell+1): aprod = C[j-1,i-1] assert lat.simple_root(i).scalar(lat.simple_coroot(j)) == aprod assert spc.simple_root(i).scalar(spc.simple_coroot(j)) == aprod assert spc.simple_root(i).scalar(lat.simple_coroot(j)) == aprod assert lat.simple_root(i).scalar(spc.simple_coroot(j)) == aprod ``` ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [X] The title is concise and informative. - [X] The description explains in detail what this PR is about. - [X] I have linked a relevant issue or discussion. - [X] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38750 Reported by: Skip G Reviewer(s): Skip G, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 9, 2024
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Goal of this PR: * Fix Exhibit A in sagemath#15325 * Exhibits B and C in the issue are ignored because they are not strictly speaking errors Status quo: * Some inner products for elements of root spaces or ambient spaces give wrong answers or raise exceptions Fix: * Adds a few lines of code to scalar product functions in ambient_space and root_space * TESTS were added to scalar product member functions to exhibit fixing this issue Notes: * I am unable to verify that the documentation builds because I cannot build the documentation (build problems with this version of Sage) A more thorough test of this functionality, which checks Exhibit A from the issue on more cases, is provided by the following code snippet: ``` for ct in [['G', 2], ['F', 4], ['E', 8], ['E', 7]] + [[x, 6] for x in ['A', 'B', 'C', 'D', 'E']]: rt = RootSystem(ct) print(ct) lat = rt.root_lattice() spc = rt.ambient_space() ell = lat.rank() C = rt.cartan_matrix() for i in range(1,ell+1): assert lat.simple_root(i) == spc.simple_root(i) assert lat.simple_coroot(i) == spc.simple_coroot(i) for j in range(1,ell+1): aprod = C[j-1,i-1] assert lat.simple_root(i).scalar(lat.simple_coroot(j)) == aprod assert spc.simple_root(i).scalar(spc.simple_coroot(j)) == aprod assert spc.simple_root(i).scalar(lat.simple_coroot(j)) == aprod assert lat.simple_root(i).scalar(spc.simple_coroot(j)) == aprod ``` ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [X] The title is concise and informative. - [X] The description explains in detail what this PR is about. - [X] I have linked a relevant issue or discussion. - [X] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38750 Reported by: Skip G Reviewer(s): Skip G, Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR:
Status quo:
Fix:
Notes:
A more thorough test of this functionality, which checks Exhibit A from the issue on more cases, is provided by the following code snippet:
📝 Checklist
⌛ Dependencies