Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use StructureDescription() in gap/element.pyx tests #38763

Merged
merged 4 commits into from
Oct 12, 2024

Conversation

dimpase
Copy link
Member

@dimpase dimpase commented Oct 3, 2024

This will fix #38760

The output of these tests is too verbose, and this unstable. We fix it here

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

Copy link

github-actions bot commented Oct 3, 2024

Documentation preview for this PR (built with commit 08f203e; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@enriqueartal
Copy link
Contributor

Adding the proposed changes, LGTM

dimpase and others added 2 commits October 4, 2024 11:50
Co-authored-by: Martin Rubey <axiomize@yahoo.de>
Co-authored-by: Martin Rubey <axiomize@yahoo.de>
Copy link
Collaborator

@mantepse mantepse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 5, 2024
    
This will fix sagemath#38760

The output of these tests is too verbose, and this unstable. We fix it
here

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#38763
Reported by: Dima Pasechnik
Reviewer(s): Martin Rubey
@fchapoton fchapoton changed the title use StructureDescrption() in gap/element.pyx tests use StructureDescription() in gap/element.pyx tests Oct 9, 2024
vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 9, 2024
    
This will fix sagemath#38760

The output of these tests is too verbose, and this unstable. We fix it
here

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#38763
Reported by: Dima Pasechnik
Reviewer(s): Martin Rubey
@vbraun vbraun merged commit 04a53cc into sagemath:develop Oct 12, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure in gap/element.pyx
4 participants