Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polynomials/fix category #38767

Merged
merged 10 commits into from
Oct 12, 2024
Merged

Conversation

mantepse
Copy link
Collaborator

@mantepse mantepse commented Oct 4, 2024

We put polynomials (and friends) into the category of algebras with basis.

Dependencies: #38729

Copy link

github-actions bot commented Oct 4, 2024

Documentation preview for this PR (built with commit 6a5aece; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@tscrim
Copy link
Collaborator

tscrim commented Oct 4, 2024

@nbruin @fchapoton @xcaruso cc-ing you in case you have some thoughts/comments about doing this.

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are no comments, then positive review. (Something I've wanted to do for awhile, thank you!)

@vbraun vbraun merged commit 67e1892 into sagemath:develop Oct 12, 2024
23 checks passed
@mantepse mantepse deleted the polynomials/fix_category branch October 13, 2024 08:42
@xcaruso
Copy link
Contributor

xcaruso commented Oct 17, 2024

Thanks @tscrim for pointing this to me and sorry for not being reactive.
I actually do not have a strong opinion on this and I'm definitely happy with your positive review.

However, I should say that I'm quite confused with the dichotomy between the classes FreeModule and CombinatorialFreeModule. I think I understand that they support different kind of features: basically the former is more oriented towards linear algebra in finite dimension, while the former allows for infinite dimensional spaces, more abstract constructions (as tensor products, etc.) and custom names for elements in a basis. But, IMO, it's really a shame because we cannot having both at the same time.

Concretely, recently, I implemented Ore modules (see #38703) and was embarrassed by this. I finally chose to derive from FreeModule because I was interested in having submodules and quotients, two constructions which are more common in the class FreeModule. However, I was not entirely convinced.

Any thoughts about this? (Please answer in #38703 - and review this PR at the same time :-))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants