-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
polynomials/fix category #38767
polynomials/fix category #38767
Conversation
…nt for MPolynomialRing_base.monomial
Documentation preview for this PR (built with commit 6a5aece; changes) is ready! 🎉 |
@nbruin @fchapoton @xcaruso cc-ing you in case you have some thoughts/comments about doing this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there are no comments, then positive review. (Something I've wanted to do for awhile, thank you!)
Thanks @tscrim for pointing this to me and sorry for not being reactive. However, I should say that I'm quite confused with the dichotomy between the classes Concretely, recently, I implemented Ore modules (see #38703) and was embarrassed by this. I finally chose to derive from Any thoughts about this? (Please answer in #38703 - and review this PR at the same time :-)) |
We put polynomials (and friends) into the category of algebras with basis.
Dependencies: #38729