faster comparison of elliptic-curve morphisms #38808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Documentation preview for this PR (built with commit 64236f9; changes) is ready! 🎉 |
|
Not sure why but doctests are failing with some unsorted issue. |
|
Oh, because you modified |
yyyyx4
force-pushed
the
public/faster_comparison_of_elliptic_curve_morphisms
branch
from
35f3f88
to
64236f9
Compare
|
Oops. Just pushed another version that only runs this check when testing |
|
I think it looks good, I'll relabel it when doctest is done. |
S17A05
approved these changes
Oct 14, 2024
|
Thanks, I forgot about it 🥲 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 17, 2024
Here we add two fast checks to the generic comparison method for elliptic-curve morphisms that will quickly detect some pairs of unequal morphisms. In the context of sagemath#35949, this speeds up the following example from 5.9 seconds to 1.8 seconds: ```sage sage: E = EllipticCurve(GF((5, 2)), [0,1]) sage: %time _ = list(E.isogenies_degree(27)) ``` URL: sagemath#38808 Reported by: Lorenz Panny Reviewer(s): Sebastian A. Spindler
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 18, 2024
Here we add two fast checks to the generic comparison method for elliptic-curve morphisms that will quickly detect some pairs of unequal morphisms. In the context of sagemath#35949, this speeds up the following example from 5.9 seconds to 1.8 seconds: ```sage sage: E = EllipticCurve(GF((5, 2)), [0,1]) sage: %time _ = list(E.isogenies_degree(27)) ``` URL: sagemath#38808 Reported by: Lorenz Panny Reviewer(s): Sebastian A. Spindler
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 20, 2024
Here we add two fast checks to the generic comparison method for elliptic-curve morphisms that will quickly detect some pairs of unequal morphisms. In the context of sagemath#35949, this speeds up the following example from 5.9 seconds to 1.8 seconds: ```sage sage: E = EllipticCurve(GF((5, 2)), [0,1]) sage: %time _ = list(E.isogenies_degree(27)) ``` URL: sagemath#38808 Reported by: Lorenz Panny Reviewer(s): Sebastian A. Spindler
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Oct 23, 2024
Here we add two fast checks to the generic comparison method for elliptic-curve morphisms that will quickly detect some pairs of unequal morphisms. In the context of sagemath#35949, this speeds up the following example from 5.9 seconds to 1.8 seconds: ```sage sage: E = EllipticCurve(GF((5, 2)), [0,1]) sage: %time _ = list(E.isogenies_degree(27)) ``` URL: sagemath#38808 Reported by: Lorenz Panny Reviewer(s): Sebastian A. Spindler
yyyyx4
deleted the
public/faster_comparison_of_elliptic_curve_morphisms
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we add two fast checks to the generic comparison method for elliptic-curve morphisms that will quickly detect some pairs of unequal morphisms. In the context of #35949, this speeds up the following example from 5.9 seconds to 1.8 seconds: