Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move orientation methods from graph.py to orientations.py #38809

Merged
merged 8 commits into from
Nov 3, 2024
Merged

move orientation methods from graph.py to orientations.py #38809

merged 8 commits into from
Nov 3, 2024

Conversation

dcoudert
Copy link
Contributor

We gather all orientation methods to file src/sage/graphs/orientations.py.
This should ease the work of #38758.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@dcoudert dcoudert mentioned this pull request Oct 12, 2024
Open
2 tasks
@dcoudert dcoudert self-assigned this Oct 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 12, 2024 •
edited
Loading

Documentation preview for this PR (built with commit f08cc2b; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@dcoudert
Copy link
Contributor Author

also move eulerian_orientation as requested by @maxale in #38758 (comment), and make it a method of Graph instead of GenericGraph.

@dcoudert
Copy link
Contributor Author

A doctest was failing when a different mip solver was used by default (cplex in my case). The new test is robust.

tscrim
tscrim approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun vbraun merged commit 1f3ede8 into sagemath:develop Nov 3, 2024
17 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

Assignees

@dcoudert dcoudert

Labels
c: graph theory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcoudert @tscrim @vbraun