Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect sparse=True in vector constructor when passed ndarray #38833

Merged
merged 2 commits into from
Oct 26, 2024
Merged

Respect sparse=True in vector constructor when passed ndarray #38833

merged 2 commits into from
Oct 26, 2024

Conversation

user202729
Copy link
Contributor

Self-explanatory.

(Of course user would not normally do this but… just in case.)

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 21, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 05e55e2; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@user202729 user202729 mentioned this pull request Oct 21, 2024
Open
5 tasks
kwankyu
kwankyu approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vbraun vbraun merged commit a90e4a3 into sagemath:develop Oct 26, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@user202729 @kwankyu @vbraun