Fix transformation parameter for LLL on matrices over QQ
#38841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit b8fa032; changes) is ready! 🎉 |
yyyyx4
added
p: major / 3
t: bug
s: positive review
c: linear algebra
and removed
s: needs review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an oversight when interpreting the result of LLL() on an integer matrix which lead to a type error. It assumed a matrix would always be returned but if
transformation=Truewas passed it would instead be a tuple. This is now fixed and a test has been added.If a
transformationparameter is added for BKZ in the future this will need to be done for it as well.📝 Checklist