Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph tikz method fixup #38847

Merged
merged 11 commits into from
Nov 3, 2024
Merged

Conversation

seblabbe
Copy link
Contributor

tikz method for graphs was recently added in #38798

default value for format should be None as documented.

⌛ Dependencies

#38798

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this branch should be rebased on last beta.

Copy link

Documentation preview for this PR (built with commit 515f3cb; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

vbraun pushed a commit to vbraun/sage that referenced this pull request Oct 26, 2024
tikz method for graphs was recently added in sagemath#38798

default value for `format` should be `None` as documented.

### ⌛ Dependencies

sagemath#38798

URL: sagemath#38847
Reported by: Sébastien Labbé
Reviewer(s): David Coudert, Frédéric Chapoton
@vbraun vbraun merged commit 47b74f7 into sagemath:develop Nov 3, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants