Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented methods pertaining to the canonical partition of a matching covered graph #38892

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

janmenjayap
Copy link
Contributor

@janmenjayap janmenjayap commented Oct 31, 2024

The objective of this issue is to implement the methods pertaining to the canonical partition of a matching covered graph.

More specifically, this PR aims to implement the following two methods:

  • maximal_barrier(): Return the (unique) maximal barrier containing the provided vertex.
  • canonical_partition(): Return the canonical partition of the (matching covered) graph.

This PR shall address the methods related to canonical partition of matching covered graphs.

Fixes #38216. Note that this issue fixes a small part of the mentioned issue.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

This PR depends on the PR #38742.

cc: @dcoudert.

Copy link

github-actions bot commented Oct 31, 2024

Documentation preview for this PR (built with commit ee8bdbd; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

src/sage/graphs/matching_covered_graph.py Outdated Show resolved Hide resolved
src/sage/graphs/matching_covered_graph.py Outdated Show resolved Hide resolved
src/sage/graphs/matching_covered_graph.py Outdated Show resolved Hide resolved
src/sage/graphs/matching_covered_graph.py Outdated Show resolved Hide resolved
src/sage/graphs/matching_covered_graph.py Outdated Show resolved Hide resolved
src/sage/graphs/matching_covered_graph.py Outdated Show resolved Hide resolved
src/sage/graphs/matching_covered_graph.py Outdated Show resolved Hide resolved
@dcoudert
Copy link
Contributor

dcoudert commented Nov 4, 2024

in the description of this PR, you say that it fixes #38216 but this is not the case. It is part of that issue, or a follow-up of that issue.

@dcoudert dcoudert added the gsoc: 2024 Tag for GSoC2024 issues/PRs label Nov 4, 2024
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the PR description, you must indicate that this PR depends on #38742

src/sage/graphs/matching_covered_graph.py Outdated Show resolved Hide resolved
Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On Decompositions, Generation Methods and related concepts in the theory of Matching Covered Graphs
2 participants