Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a few details in combinat, following ruff and pycodestyle #38903

Merged
merged 2 commits into from
Nov 16, 2024
Merged

a few details in combinat, following ruff and pycodestyle #38903

merged 2 commits into from
Nov 16, 2024

Conversation

fchapoton
Copy link
Contributor

just fixing a few ruff PERF suggestions in 4 files

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 826f34f; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

vincentmacri
vincentmacri suggested changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@vincentmacri vincentmacri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small things. Looks good otherwise!

src/sage/combinat/tableau.py Show resolved Hide resolved
src/sage/combinat/words/finite_word.py Show resolved Hide resolved
src/sage/combinat/rigged_configurations/kleber_tree.py Outdated Show resolved Hide resolved
vincentmacri
vincentmacri approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@vincentmacri vincentmacri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'll set it to positive review once the CI run is finished unless there is a failure that looks relevant.

mantepse
mantepse approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@mantepse mantepse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bots are happy, me too!

tscrim
tscrim approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 5, 2024
sagemathgh-38903: a few details in combinat, following ruff and pycod…
4a1f612 
…estyle

    
just fixing a few ruff PERF suggestions in 4 files

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#38903
Reported by: Frédéric Chapoton
Reviewer(s): Frédéric Chapoton, Martin Rubey, Travis Scrimshaw, Vincent Macri
vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 6, 2024
sagemathgh-38903: a few details in combinat, following ruff and pycod…
dd6aba9 
…estyle

    
just fixing a few ruff PERF suggestions in 4 files

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#38903
Reported by: Frédéric Chapoton
Reviewer(s): Frédéric Chapoton, Martin Rubey, Travis Scrimshaw, Vincent Macri
vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 7, 2024
sagemathgh-38903: a few details in combinat, following ruff and pycod…
c816419 
…estyle

    
just fixing a few ruff PERF suggestions in 4 files

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#38903
Reported by: Frédéric Chapoton
Reviewer(s): Frédéric Chapoton, Martin Rubey, Travis Scrimshaw, Vincent Macri
vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 8, 2024
sagemathgh-38903: a few details in combinat, following ruff and pycod…
a9d5fa2 
…estyle

    
just fixing a few ruff PERF suggestions in 4 files

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#38903
Reported by: Frédéric Chapoton
Reviewer(s): Frédéric Chapoton, Martin Rubey, Travis Scrimshaw, Vincent Macri
vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 9, 2024
sagemathgh-38903: a few details in combinat, following ruff and pycod…
ff0a387 
…estyle

    
just fixing a few ruff PERF suggestions in 4 files

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#38903
Reported by: Frédéric Chapoton
Reviewer(s): Frédéric Chapoton, Martin Rubey, Travis Scrimshaw, Vincent Macri
vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 13, 2024
sagemathgh-38903: a few details in combinat, following ruff and pycod…
0e473f3 
…estyle

    
just fixing a few ruff PERF suggestions in 4 files

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#38903
Reported by: Frédéric Chapoton
Reviewer(s): Frédéric Chapoton, Martin Rubey, Travis Scrimshaw, Vincent Macri
@vbraun vbraun merged commit 69a8c02 into sagemath:develop Nov 16, 2024
27 of 28 checks passed
@fchapoton fchapoton deleted the some_ruff_combi branch November 16, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincentmacri vincentmacri vincentmacri approved these changes

@mantepse mantepse mantepse approved these changes

@tscrim tscrim tscrim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fchapoton @tscrim @mantepse @vincentmacri @vbraun