use sig_realloc
in method OP_make_set
#38936
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method
OP_make_set
was introduced in #38692 in filesrc/sage/groups/perm_gps/partn_ref/data_structures.pxd
to add the methodmake_set
toDisjointSet
(i.e., the ability to add a new element to a disjoint set).We improve the method by using
sig_realloc
rather than a combination ofsig_malloc
andmemcpy
. This requires some changes in methodsOP_new
andOP_dealloc
.📝 Checklist
⌛ Dependencies