Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use sig_realloc in method OP_make_set #38936

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

dcoudert
Copy link
Contributor

@dcoudert dcoudert commented Nov 7, 2024

Method OP_make_set was introduced in #38692 in file src/sage/groups/perm_gps/partn_ref/data_structures.pxd to add the method make_set to DisjointSet (i.e., the ability to add a new element to a disjoint set).

We improve the method by using sig_realloc rather than a combination of sig_malloc and memcpy. This requires some changes in methods OP_new and OP_dealloc.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@dcoudert dcoudert self-assigned this Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

Documentation preview for this PR (built with commit ffd675a; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant