Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken rendering of adjacent code blocks #38981

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Fix broken rendering of adjacent code blocks #38981

merged 2 commits into from
Nov 23, 2024

Conversation

kwankyu
Copy link
Collaborator

@kwankyu kwankyu commented Nov 17, 2024 •
edited
Loading

a bug seen in, for example: https://doc-release--sagemath.netlify.app/html/en/reference/structure/sage/structure/category_object#sage.structure.category_object.CategoryObject.variable_names

Compare with the fixed page: https://doc-pr-38981--sagemath.netlify.app/html/en/reference/structure/sage/structure/category_object#sage.structure.category_object.CategoryObject.variable_names

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@kwankyu kwankyu changed the title Materialize literal-blocks list before modifying nodes Fix broken rendering of adjacent code blocks Nov 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 17, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 7279faa; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@kwankyu kwankyu marked this pull request as ready for review November 17, 2024 09:18
fchapoton
fchapoton approved these changes Nov 17, 2024
View reviewed changes
Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, if you say so

@kwankyu
Copy link
Collaborator Author

kwankyu commented Nov 17, 2024

Thanks!

@kwankyu kwankyu added p: CI Fix merged before running CI tests and removed p: CI Fix merged before running CI tests labels Nov 17, 2024
@vbraun vbraun merged commit 95eb9b8 into sagemath:develop Nov 23, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchapoton fchapoton fchapoton approved these changes

Assignees
No one assigned
Labels
p: blocker / 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kwankyu @fchapoton @vbraun