Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Fix: Do not upload logs artifact for the default job in CI Linux #39003

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

kwankyu
Copy link
Collaborator

@kwankyu kwankyu commented Nov 19, 2024

fixes the failure seen in https://github.com/sagemath/sage/actions/runs/11869791506/job/33080484685

The cause is duplicate uploading of artifacts of the same name.

Test: https://github.com/kwankyu/sage/actions/runs/11906298470/job/33178163324

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@kwankyu kwankyu changed the title Do not upload logs artifact for the default job CI Fix: Do not upload logs artifact for the default job in CI Linux Nov 19, 2024
@kwankyu kwankyu marked this pull request as ready for review November 19, 2024 22:43
Copy link

Documentation preview for this PR (built with commit 8377403; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Nov 26, 2024

Thanks again!

vbraun pushed a commit to vbraun/sage that referenced this pull request Nov 26, 2024
… job in CI Linux

<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

fixes the failure seen in https://github.com/sagemath/sage/actions/runs/
11869791506/job/33080484685

The cause is duplicate uploading of artifacts of the same name.

Test:
https://github.com/kwankyu/sage/actions/runs/11906298470/job/33178163324

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

URL: sagemath#39003
Reported by: Kwankyu Lee
Reviewer(s):
@vbraun vbraun merged commit cb6ca56 into sagemath:develop Nov 30, 2024
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants