add commenting functionality to document editing #8071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e what's stored doesn't match the latest document version
…ble (work in progress)
- very much work in progress
- not worried about speed yet - doesn't work for multiple cursor selections
…presentation of all comment mark states over time using a doubly linked list with deltas
- not used for anything yet - not optimized for performance
…lt fallback for backward compat, and takes into account snapshots (any head form before a snapshot is ignored)
williamstein
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns out to be difficult since we are going to fully support storing the complete TimeTravel edit history of where all comments are located, and this requires a somewhat more sophisticated approach to our sync framework that fully supports branching and merging.