Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crateinfo: do not sort workspace members #897

Merged
merged 1 commit into from
Jul 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/lib/environment/crateinfo.rs
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,6 @@ fn add_members(crate_info: &mut CrateInfo, new_members: Vec<String>) {
fn dedup_members(crate_info: &mut CrateInfo) {
if let Some(ref mut workspace) = crate_info.workspace {
if let Some(ref mut members) = workspace.members {
members.sort();
members.dedup();
}
}
Expand Down
18 changes: 18 additions & 0 deletions src/lib/environment/crateinfo_test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,24 @@ fn add_members_workspace_new_members_with_data() {
assert_eq!(workspace.members.unwrap().len(), 2);
}

#[test]
fn add_members_workspace_non_alpha_ordered() {
let mut crate_info = CrateInfo::new();

crate_info.workspace = Some(Workspace::new());
add_members(
&mut crate_info,
vec!["test2".to_string(), "test1".to_string()],
);

load_workspace_members(&mut crate_info);

let members = crate_info.workspace.unwrap().members.unwrap();
assert_eq!(members.len(), 2);
assert_eq!(members[0], "test2".to_owned());
assert_eq!(members[1], "test1".to_owned());
}

#[test]
fn add_members_workspace_empty_members_with_data() {
let mut crate_info = CrateInfo::new();
Expand Down
Loading