Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix max sizes on x86, part of the fix for #522 #523

Closed
wants to merge 1 commit into from
Closed

Fix max sizes on x86, part of the fix for #522 #523

wants to merge 1 commit into from

Conversation

sbraz
Copy link
Contributor

@sbraz sbraz commented Sep 8, 2021

strtoull returns ULLONG_MAX, not ULONG_MAX.

@sbraz
Copy link
Contributor Author

sbraz commented Sep 8, 2021

Actually please don't merge this yet, --size 0-18446744073709551615.1 doesn't trigger an error.

@sbraz
Fix max sizes on x86, part of the fix for sahib#522
fa1640e 
strtoull returns ULLONG_MAX, not ULONG_MAX.
@sbraz
Copy link
Contributor Author

sbraz commented Sep 8, 2021

I don't really know why that fraction is supposed to fail here:

rmlint/lib/cmdline.c

Line 387 in 427791c

g_set_error(error, RM_ERROR_QUARK, 0, _("Size factor would overflow size (max. 2**64 allowed)"));

I'll leave this PR in its current state, as an incomplete fix for #522.

@sbraz sbraz changed the title Fix max sizes on x86, closes #522 Fix max sizes on x86, part of the fix for #522 Sep 8, 2021
@cebtenzzre cebtenzzre linked an issue Aug 15, 2022 that may be closed by this pull request
test_size.test_invalid fails on x86 #522
Closed
@cebtenzzre
Copy link
Collaborator

Fixed in 4043c79.

@cebtenzzre cebtenzzre closed this Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_size.test_invalid fails on x86
2 participants
@sbraz @cebtenzzre