Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sh: support reflinking directories #619

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

intelfx
Copy link

@intelfx intelfx commented Mar 10, 2023

There are no technical limitations preventing the use of cp -a --reflink=always on directory pairs. With a few extensions to attribute preservation code, this seems to produce correct results.

  • modify rm_util_link_type() to specifically detect directory pairs
  • modify sh output generator to emit cp_reflink for directory pairs
  • modify sh template to support reflinking directories and extend
    stampfile code to preserve attributes recursively

This also builds on @cebtenzzre's patch improving stampfile handling in the sh output generator.

Fixes #618.

cebtenzzre and others added 3 commits March 9, 2023 21:43
- mktemp in /tmp
- don't assume $0 is a file
- remove stampfiles at exit
- don't create stampfiles if -n is passed

Closes sahib#554
- modify rm_util_link_type() to specifically detect directory pairs
- modify sh output generator to emit cp_reflink for directory pairs
- modify sh template to support reflinking directories and extend
  stampfile code to preserve attributes recursively

Fixes sahib#618.
@cebtenzzre cebtenzzre linked an issue Mar 16, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFE: support reflinking directories
2 participants