Fix example and language in manpage #636
Conversation
| This command makes ``rmlint`` exit with one of the following exit codes: | ||
|
|
||
| * 0: files are reflinks | ||
| * 1: files are not reflinks | ||
| * 3: not a regular file | ||
| * 4: file sizes differ | ||
| * 5: fiemaps can't be read | ||
| * 6: file1 and file2 are the same path | ||
| * 6: file1 and file2 are at the same path |
There was a problem hiding this comment.
I'm not sure about this change. This status is for when the two paths provided are literally the same path after resolving symlinks, hence no data needs to be looked at. Maybe we could say "have the same path", but I'd have to think about it - technically, no two files can have the same path, because that would mean they're the same file.
There was a problem hiding this comment.
Maybe "path1" and "path2" are more suitable argument names. Then this could read:
6: path1 and path2 point to the same file (after resolving symlinks)
Come to think of it, this sounds reasonable as well:
6: file1 and file2 are the same (after resolving symlinks)
There was a problem hiding this comment.
Well, "the same file" is ambiguous here, because it could be taken to mean "the same inode." But that's a hardlink - two different paths that point to the same file. The paths themselves are equal after resolving symlinks in this case.
Hi and thanks a lot for rmlint!
I'd like to offer some improvements for the manpage.
It's mostly typo fixes and attempts to make the manpage easier to read.
But I think I also spotted an error in the examples. In the old version,
rmlint -ewas described asYet I'm pretty sure that option
-bdoes that, whereas-emakes rmlint consider two files as duplicates only if their extensions match.