Debug info on timeout #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Distinguish command timeout from outqueue or waitqueue. For example, A command sequence: ...NOP,READ,WRITE... NOP OUT command has no dependence on backend media, it is expected to response soon. Once NOP timeout in libiscsi: a, the command is already sent to target, the target side does *not* response. b, the command is still pending in libiscsi. Separate the two cases for trouble shooting. Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
These value-string maps is read-only, it should be constructed once during loading binary. Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
Convert SCSI opcode into string for trouble shooting. Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
Now we have more friendly opcode message once error occurs:
libiscsi:1 command timed out from waitqueue [...]
libiscsi:2 PDU header: 01 c1 ... e9 88[READ16] 00 00 00 ...
^(human readable opcode string)
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
|
merged thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several patches for command timeout trouble shooting.