Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config.py] Add missing config.source_code_url value #14

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

Olf0
Copy link
Contributor

@Olf0 Olf0 commented Feb 27, 2024

The string source_code_url only occurs twice:

I.e., there is no other user of this configuration parameter than about-generator.html.
I do not comprehend why this link defaulted to the page displayed (https://sailfishos-chum.github.io/about-generator.html), but so what, probably a property of the tooling used.

Fixes last paragraph of #13 (comment).

@Olf0 Olf0 self-assigned this Feb 27, 2024
@Olf0 Olf0 changed the title [config.py] Add missing config.source_code_url [config.py] Add missing config.source_code_url value Feb 27, 2024
@Olf0
Copy link
Contributor Author

Olf0 commented Feb 27, 2024

@HenkKalkwater, please review this PR and then PR #15, which goes on top of this PR #14.

I will gladly do the merging, but I first would like your review comprising quality assurance (on technical aspects) and opinion (on all non-technical aspects).

@HenkKalkwater
Copy link
Collaborator

The link in the generated HTML is <a href="">…</a> and that apparently simply causes a page reload. This PR looks like how I intended it to work, so thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants