Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patchmanager.cpp] Reintroduce two dummy methods for documentation … #452

Merged
merged 5 commits into from
May 8, 2024

Conversation

Olf0
Copy link
Contributor

@Olf0 Olf0 commented Aug 15, 2023

… purposes only in order to silence qdoc warnings WRT undocumented classes, methods and functions.
Reference: The core aspect of the whole back and forth in PR #451: #451

…rposes only

Reference: The core aspect of the whole back and forth in PR #451: #451
@Olf0 Olf0 marked this pull request as draft August 15, 2023 23:08
@Olf0
Copy link
Contributor Author

Olf0 commented Aug 15, 2023

@nephros: Trying to resurrect this, adding all the info gathered meanwhile.
Please alter it to your liking, e.g., your original, unchanged documentation text lines (two for each method).

The dummy operations utilising patch and version respectively easterText still need to be implemented, see the corresponding [-Werror=unused-parameter] outputs.

@Olf0 Olf0 changed the title [patchmanager.cpp] Reintroduce two dummy methods for documentation purposes only [patchmanager.cpp] Reintroduce two dummy methods for documentation … Aug 15, 2023
@nephros nephros marked this pull request as ready for review May 6, 2024 16:28
@Olf0
Copy link
Contributor Author

Olf0 commented May 8, 2024

Oh, I completely forgot about this and rereading the changes now (almost a year after writing them) does not bring memories back. As I assume this still makes sense (though I do not know that any longer), and both @b100dian and @nephros do not object, I will merge this.

@Olf0 Olf0 merged commit 3c19765 into master May 8, 2024
1 check passed
@Olf0 Olf0 deleted the silence-qdoc-warnings-v2 branch May 8, 2024 14:00
nephros pushed a commit to nephros/patchmanager that referenced this pull request May 28, 2024
nephros pushed a commit to nephros/patchmanager that referenced this pull request May 28, 2024
nephros pushed a commit to nephros/patchmanager that referenced this pull request May 28, 2024
nephros pushed a commit to nephros/patchmanager that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants