-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port Sonokai color scheme to iTerm2 themes #115
Comments
Good job! Since the color palette is designed for syntax and not for a general purpose (terminals, web, etc.), you might want to apply a shade to the colors 0-7 to create bright variants, like I suggested here: We don't want to change the palette in the Vim colorscheme, but it doesn't mean that you can't do your own interpretation of it in derivatives. As long as the base palette is being prominently used, it's still Sonokai 🙂 |
Thanks! I actually prefer having a uniform experience between the native terminal and Vim embedded terminal, and I didn't feel like the UX was impacted negatively by the absence of bright colors (at least for the tools I use). Other popular themes also have equal normal and bright colors (e.g., Tokyo Night, Rose Pine, Monokai Classic, Monokai Pro, Tomorrow Night, etc.). If you prefer having dedicated bright colors, do you have suggestions for the palette? |
Fair enough. I don't usually use terminal colors contributed by the community for the opposite reason: they often don't respect bright semantics very well (either reverse them arbitrarily or don't differentiate between non-bright and bright at all). I explained my reasoning here: sainnhe/gruvbox-material#152 (comment). I also don't use the Vim terminal for similar reasons (degradation/inconsistencies of colors), so I don't think my opinion should be authoritative here with regards to sonokai or any other of sainnhe's colorschemes. Based on discussions I followed in various GitHub issues, there are 2 opposite opinions on this:
So, pick a camp I guess 🙂
In my own dotfiles I have base colors lightened (dark mode) or darkened (light mode) by 10 points in the OKHSL color space. |
Thanks for the explanations! I prefer the consistency and will keep the 8-color palette for now. If need be, I think it's a lot less disruptive to add support for bright colors later than the other way around. |
See details in sainnhe/sonokai#115.
See https://github.com/sainnhe/sonokai: - ANSI colors are the Vim terminal colors - Cursor color is the Vim auto `Cursor` highlight (inverts `fg` and `bg0`) - Selection background is the Vim `Visual` highlight - Selection text foreground doesn't change See details in sainnhe/sonokai#115.
See https://github.com/sainnhe/sonokai: - ANSI colors are the Vim terminal colors - Cursor color is the Vim auto `Cursor` highlight (inverts `fg` and `bg0`) - Selection background is the Vim `Visual` highlight - Selection text foreground doesn't change See details in sainnhe/sonokai#115.
iTerm2 has an extensive list of themes, with auto-generated ports for most terminals: https://github.com/mbadolato/iTerm2-Color-Schemes.
I created a port to iTerm2 themes for the default Sonokai color scheme as follows:
Cursor
highlight, which reversesfg
andbg0
Visual
highlightfg
#FFFFFF
to differentiate from regular foregroundExample screenshot:

Before I send the pull request, I would like to know if you agree / approve of the port, and if you have any suggestions for the colors.
You're also welcome to review the commit for the color palette of one of the terminals (they're all auto-generated from the iTerm2 scheme, so they're all the same).
The text was updated successfully, but these errors were encountered: