SAK-50066 Date Manager export and import csv fixes #12714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesusmmp
reviewed
Jul 8, 2024
| if (announcement.getProperties().getProperty(AnnouncementService.RETRACT_DATE) != null) { | ||
| changed = changed || this.compareDates(Date.from(announcement.getProperties().getInstantProperty(AnnouncementService.RETRACT_DATE)), columns[3]); | ||
| if (retractDateActive) { | ||
| changed = changed || this.compareDates(Date.from(announcement.getProperties().getInstantProperty(AnnouncementService.RETRACT_DATE)), releaseDateActive? columns[3] : columns[2]); |
There was a problem hiding this comment.
changed = changed || this.compareDates(Date.from(retractDateActive), releaseDateActive? columns[3] : columns[2]); ?
jesusmmp
reviewed
Jul 8, 2024
| if (announcement.getProperties().getProperty(AnnouncementService.RELEASE_DATE) != null) { | ||
| boolean releaseDateActive = announcement.getProperties().getProperty(AnnouncementService.RELEASE_DATE) != null; | ||
| boolean retractDateActive = announcement.getProperties().getProperty(AnnouncementService.RETRACT_DATE) != null; | ||
| if (releaseDateActive) { | ||
| changed = changed || this.compareDates(Date.from(announcement.getProperties().getInstantProperty(AnnouncementService.RELEASE_DATE)), columns[2]); |
There was a problem hiding this comment.
changed = changed || this.compareDates(Date.from(releaseDateActive ), columns[2]); ?
|
Hey @jesusmmp. I tried to apply the modifications that you suggest, but the problem is that the getInstantProperty cannot be null, and need to be incorporated after checked that exist |
JuanDavid102
force-pushed
the
SAK-50066-b
branch
2 times, most recently
from
3ade5d1
to
8e14eac
Compare
JuanDavid102
force-pushed
the
SAK-50066-b
branch
from
8e14eac
to
e0877a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.