Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix older gdb breakpoints parse bugs #207

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Conversation

jxlpzqc
Copy link
Contributor

@jxlpzqc jxlpzqc commented Aug 7, 2024

When encountered breakpoint in gdb output as following, parser will not consider Ena as "y".

Num     Type           Disp Enb Address            What
1       breakpoint     keep y   <MULTIPLE>         
1.1                         y   0xffff800080d90414 in __arch_counter_get_cntvct at ./arch/arm64/include/asm/arch_timer.h:204
1.2                         y   0xffff800081014f10 in __arch_counter_get_cntvct at ./arch/arm64/include/asm/arch_timer.h:204

@sakhnik
Copy link
Owner

sakhnik commented Aug 11, 2024

Thanks for your contribution! I've run the tests locally in Linux, and they pass. Could you please merge upstream/devel or rebase on top of it to run the tests in github actions for macos and windows?

@jxlpzqc
Copy link
Contributor Author

jxlpzqc commented Aug 12, 2024

@sakhnik Thank you, I have rebased on top of upstream/devel.

When encountered <MULTIPLE> breakpoint in gdb output
as following, parser will not consider Ena as "y".

```
Num     Type           Disp Enb Address            What
1       breakpoint     keep y   <MULTIPLE>
1.1                         y   0xffff800080d90414 in __arch_counter_get_cntvct at ./arch/arm64/include/asm/arch_timer.h:204
1.2                         y   0xffff800081014f10 in __arch_counter_get_cntvct at ./arch/arm64/include/asm/arch_timer.h:204
```
@sakhnik sakhnik merged commit 2ab24b3 into sakhnik:master Aug 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants