Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

使用しないメソッド引数のマーキングにmaybe_unused属性を使う #1174

Merged
merged 1 commit into from
Jan 27, 2020
Merged

使用しないメソッド引数のマーキングにmaybe_unused属性を使う #1174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions sakura_core/extmodule/CIcu4cI18n.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,8 @@ CIcu4cI18n::~CIcu4cI18n() noexcept
/*!
* @brief DLLの名前を返す
*/
LPCWSTR CIcu4cI18n::GetDllNameImp(int index)
LPCWSTR CIcu4cI18n::GetDllNameImp( [[maybe_unused]] int index )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

メモ

https://docs.microsoft.com/ja-jp/cpp/cpp/attributes
vc でも対応してるみたい

{
(void*)index;
return L"icuin66.dll"; //バージョンは固定
}

Expand Down