GrepとGrep置換ダイアログの微調整 #1242
Merged
GrepとGrep置換ダイアログの微調整 #1242
+52
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build sakura 1.0.2711 completed (commit 7c3f874409 by @7-rate) |
beru
previously approved these changes
Apr 24, 2020
忘れそうなので一緒に直したいですね。 |
|
英語版も上フォルダボタン等も一緒に直してしまうのは同意ですが、英語版の動作確認方法が分からないです。どこかに書いてありますか？ |
|
自己解決しました。 |
英語版：除外ファイル、結果出力のUI位置調整
|
指摘内容以外に除外ファイルの位置も微調整しました。 |
|
✅ Build sakura 1.0.2719 completed (commit 858f64f8ec by @7-rate) |
m-tmatma
approved these changes
Apr 26, 2020
beru
approved these changes
Apr 26, 2020
beru
approved these changes
Apr 26, 2020
HoppingTappy
pushed a commit
to HoppingTappy/sakura
that referenced
this pull request
Jun 16, 2020
GrepとGrep置換ダイアログの微調整
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR の目的
GrepダイアログとGrep置換ダイアログの「結果出力」が除外フォルダの入力ボックスに近くて見づらいという問題があります。
それを解消します。
カテゴリ
UIの微調整のみです。
PR の背景
目的に書いた通り。
PR のメリット
GrepダイアログとGrep置換ダイアログが見やすくなります
PR のデメリット (トレードオフとかあれば)
特になし
PR の影響範囲
UIの微調整のみであるため無し
関連チケット
特になし
参考資料
変更前後の画像を貼ります。
Grepダイアログ-日本語
Grep置換ダイアログ-日本語
Grepダイアログ-英語
Grep置換ダイアログ-英語