Combo_AddString の戻り値の型を int にする #1291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Build sakura 1.0.2797 completed (commit c84e15b716 by @m-tmatma) |
berryzplus
approved these changes
May 10, 2020
| { | ||
| return ::SendMessage( hwndCombo, CB_ADDSTRING, 0, LPARAM(str) ); | ||
| // CB_ADDSTRING は失敗の時、負の値を返す。 |
There was a problem hiding this comment.
負の値の中身は決まりごとなので具体値を書いてもいい気がしました。
CB_ERR(-1)なんか失敗CB_ERRSPACE(-2)メモリ不足で失敗
| // CB_ADDSTRING は失敗の時、負の値を返す。 | ||
| // 成功した場合 0 ベースのインデックスを返す。 | ||
| // 64bit 対応時に int で十分 | ||
| return (int)::SendMessage( hwndCombo, CB_ADDSTRING, 0, LPARAM(str) ); |
There was a problem hiding this comment.
今回の対応範囲じゃないんですが、C-Styleキャストを追加するなら末尾のLPARAM(str)も合わせてはどうかと思いました。
LPARAM(str) は Function-Styleキャストというやつで、C-Styleキャストとは少し意味が違ったはず。どう違うのか詳しくは知らんです。
HoppingTappy
pushed a commit
to HoppingTappy/sakura
that referenced
this pull request
Jun 16, 2020
…rn-of-Combo_AddString Combo_AddString の戻り値の型を int にする
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(必須) PR の目的
64bit 対応のために警告を減らす対応の一部で Combo_AddString の戻り値の型を int にする
(必須) カテゴリ
(自明なら省略可) PR の背景
(自明なら省略可) PR のメリット
64bit ビルドで警告が減る
(なければ省略可) PR のデメリット (トレードオフとかあれば)
なし
(仕様変更/機能追加の場合は必須) 仕様・動作説明
(必須) テスト内容
appveyor で警告の数を比較
release x64 592個 → 572個
debug x64 623個 → 603個
(わかる範囲で) PR の影響範囲
combobox への追加操作
(なければ省略可) 関連 issue, PR
#430
(なければ省略可) 参考資料
https://docs.microsoft.com/en-us/windows/win32/controls/cb-addstring