iss ファイルでコメント感がもう少しわかりやすいようにする #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
自体消してもいいのだが。 |
|
✅ Build sakura 1.0.2998 completed (commit 91ed43a4c0 by @m-tmatma) |
takke
approved these changes
Aug 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR の目的
iss ファイルでコメント感がもう少しわかりやすいようにする
カテゴリ
PR の背景
#1369 をきっかけに、i18n 対応の漏れを探していたら #1370 を起票したが、
実際にはコメントで問題のないコードだったが、
iss ファイルの文法に慣れていないせいもあるが、ぱっと見で、日本語を直接埋め込んでいると
思ってしまったので、もう少しコメントであることがわかりやすいようにする。
PR のメリット
#1370 を i18n 対応漏れと勘違いしなくなる
PR のデメリット (トレードオフとかあれば)
なし
仕様・動作説明
テスト内容
テスト1
手順
PR の影響範囲
関連 issue, PR
fixes #1370
参考資料