CodeFactorで検出されたps1の問題を修正するためlistzip.ps1を書き直す #1447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
・Write-Hostは実装されていないプラットフォームがあるので使うべきでないらしいです。 ・catchブロックを書くなら空にすべきではないそうです。
|
✅ Build sakura 1.0.3207 completed (commit 897689fcca by @berryzplus) |
sanomari
approved these changes
Oct 29, 2020
|
レビューありがとうございます。マージしちゃいます。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR の目的
CodeFactorで検出されたps1の問題を修正するためlistzip.ps1を書き直します。
カテゴリ
PR の背景
この警告に対応するための修正です。
https://www.codefactor.io/repository/github/sakura-editor/sakura/issues?lang=27
検出されt問題に対処するために、根本的に書き換えてしまったのでリファクタリングじゃないです。
PR のメリット
PR のデメリット (トレードオフとかあれば)
仕様・動作説明
テスト内容
テスト1
手順
PR の影響範囲
関連 issue, PR
参考資料
https://takamaruo.hatenablog.com/entry/2018/10/02/232227