Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SonarCloudで検出されたCDlgExec::SetDataのコーディングミスを修正する #1586

Merged
merged 1 commit into from
Mar 14, 2021

Conversation

berryzplus
Copy link
Contributor

PR の目的

SonarScanで検出されたBugsレベル警告により発覚した実害のないバグ(?)に対処します。

カテゴリ

  • 不具合修正

PR の背景

SonarScanで以下のBugsレベル警告が検出されています。

Out of bound memory access (access exceeds upper limit of memory block)
https://sonarcloud.io/project/issues?id=sakura-editor_sakura&issues=AW8eyhPUak1yqJchwkqI&open=AW8eyhPUak1yqJchwkqI

PR のメリット

PR のデメリット (トレードオフとかあれば)

仕様・動作説明

forループの条件式がおかしいのを修正します。

for( i = 0; _countof(codeTable1); i++ ){
if( codeTable1[i] == nOpt ){

PR の影響範囲

テスト内容

ビルド確認のみです。

関連 issue, PR

#1504

参考資料

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AppVeyorBot
Copy link

@berryzplus
Copy link
Contributor Author

レビューありがとうございます。マージしちゃいます。

@berryzplus berryzplus merged commit 005bd41 into sakura-editor:master Mar 14, 2021
@berryzplus berryzplus deleted the feature/fix_loop_limits branch March 14, 2021 07:59
@beru beru added the 🐛bug🦋 ■バグ修正(Something isn't working) label Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug🦋 ■バグ修正(Something isn't working)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants